Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1160B91B8 for ; Mon, 24 Sep 2012 20:20:09 +0000 (UTC) Received: (qmail 16331 invoked by uid 500); 24 Sep 2012 20:20:08 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 16288 invoked by uid 500); 24 Sep 2012 20:20:08 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 16231 invoked by uid 99); 24 Sep 2012 20:20:08 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 24 Sep 2012 20:20:08 +0000 Date: Tue, 25 Sep 2012 07:20:08 +1100 (NCT) From: "Cody Marcel (JIRA)" To: issues@hbase.apache.org Message-ID: <1612564986.118452.1348518008159.JavaMail.jiratomcat@arcas> In-Reply-To: <1529174716.24751.1305761691368.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Updated] (HBASE-3896) Make AssignmentManager standalone testable by having its constructor take Interfaces rather than a CatalogTracker and a ServerManager MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-3896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cody Marcel updated HBASE-3896: ------------------------------- Assignee: Cody Marcel > Make AssignmentManager standalone testable by having its constructor take Interfaces rather than a CatalogTracker and a ServerManager > ------------------------------------------------------------------------------------------------------------------------------------- > > Key: HBASE-3896 > URL: https://issues.apache.org/jira/browse/HBASE-3896 > Project: HBase > Issue Type: Task > Reporter: stack > Assignee: Cody Marcel > > If we could stand up an instance of AssignmentManager, a core fat class that has a bunch of critical logic managing state transitions, then it'd be easier writing unit tests around its logic. Currently its hard because it takes a ServerManager and a CatalogTracker, but a little bit of work could turn these into Interfaces. SM looks easy to do. Changing CT into an Interface instead might ripple a little through the code base but it'd probably be well worth it. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira