hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-6698) Refactor checkAndPut and checkAndDelete to use doMiniBatchMutation
Date Mon, 10 Sep 2012 20:53:07 GMT

    [ https://issues.apache.org/jira/browse/HBASE-6698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13452432#comment-13452432
] 

stack commented on HBASE-6698:
------------------------------

I took a look at the first change:

{code}
-        prepareDelete(delete);
-        internalDelete(delete, delete.getClusterId(), writeToWAL);
+        doBatchMutate(delete, lid);
{code}

If I look at doBatchMutate, it is missing special handling that prepareDelete does: e.g. the
piece in prepareDelete where if no column family is specified, we set for each column family
in the HTableDescriptor, a special cell w/ the current timestamp.

My worry is that corner cases are not covered by this mass replace.  Please convince me its
just my bad review not catching them.  Thanks Priyadarshini.
                
> Refactor checkAndPut and checkAndDelete to use doMiniBatchMutation
> ------------------------------------------------------------------
>
>                 Key: HBASE-6698
>                 URL: https://issues.apache.org/jira/browse/HBASE-6698
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: ramkrishna.s.vasudevan
>             Fix For: 0.96.0
>
>         Attachments: HBASE-6698_1.patch, HBASE-6698_2.patch, HBASE-6698_3.patch, HBASE-6698_5.patch,
HBASE-6698_6.patch, HBASE-6698_6.patch, HBASE-6698_6.patch, HBASE-6698_6.patch, HBASE-6698.patch
>
>
> Currently the checkAndPut and checkAndDelete api internally calls the internalPut and
internalDelete.  May be we can just call doMiniBatchMutation
> only.  This will help in future like if we have some hooks and the CP
> handles certain cases in the doMiniBatchMutation the same can be done while
> doing a put thro checkAndPut or while doing a delete thro checkAndDelete.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message