hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-6669) Add BigDecimalColumnInterpreter for doing aggregations using AggregationClient
Date Tue, 04 Sep 2012 19:31:08 GMT

    [ https://issues.apache.org/jira/browse/HBASE-6669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13447983#comment-13447983
] 

Ted Yu commented on HBASE-6669:
-------------------------------

@Anil:
Can you attach patch for trunk where BigDeciamlColumnInterpreter resides in hbase-server module
?
Please add following annotation to BigDeciamlColumnInterpreter class:
{code}
@InterfaceAudience.Public
@InterfaceStability.Evolving
{code}
Why did you choose 0.0D / 0.0D in divideForAvg() ?
{code}
+ public double divideForAvg(BigDecimal val1, Long paramLong) {
+   return (((paramLong == null) || (val1 == null)) ? (0.0D / 0.0D) : val1.doubleValue()/paramLong.doubleValue());
{code}
See HBASE-3678 for an Eclipse formatter.
Limit line length to 100 characters.

Thanks
                
> Add BigDecimalColumnInterpreter for doing aggregations using AggregationClient
> ------------------------------------------------------------------------------
>
>                 Key: HBASE-6669
>                 URL: https://issues.apache.org/jira/browse/HBASE-6669
>             Project: HBase
>          Issue Type: New Feature
>          Components: client, coprocessors
>            Reporter: Anil Gupta
>            Priority: Minor
>              Labels: client, coprocessors
>         Attachments: BigDecimalColumnInterpreter.java, BigDecimalColumnInterpreter.patch
>
>
> I recently created a Class for doing aggregations(sum,min,max,std) on values stored as
BigDecimal in HBase. I would like to commit the BigDecimalColumnInterpreter into HBase. In
my opinion this class can be used by a wide variety of users. Please let me know if its not
appropriate to add this class in HBase.
> Thanks,
> Anil Gupta
> Software Engineer II, Intuit, Inc 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message