hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "nkeywal (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-6702) ResourceChecker refinement
Date Thu, 20 Sep 2012 08:57:07 GMT

    [ https://issues.apache.org/jira/browse/HBASE-6702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13459459#comment-13459459
] 

nkeywal commented on HBASE-6702:
--------------------------------

Yeah. I don't have any opinion in the field vs. common base class approach. Both are ok to
me. What I don't remember is if I was not constrained by the JUnit annotation approach. I
just remember I had to try multiple options, before finding a suitable one. Something to consider
as well is to declare the runlistener in the pom. I know I didn't try it at this time, but
it could be simpler actually (it would be nothing to add at all :-) ). I will give it a try.
                
> ResourceChecker refinement
> --------------------------
>
>                 Key: HBASE-6702
>                 URL: https://issues.apache.org/jira/browse/HBASE-6702
>             Project: HBase
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 0.96.0
>            Reporter: Jesse Yates
>            Priority: Critical
>             Fix For: 0.96.0
>
>
> This was based on some discussion from HBASE-6234.
> The ResourceChecker was added by N. Keywal to help resolve some hadoop qa issues, but
has since not be widely utilized. Further, with modularization we have had to drop the ResourceChecker
from the tests that are moved into the hbase-common module because bringing the ResourceChecker
up to hbase-common would involved bringing all its dependencies (which are quite far reaching).
> The question then is, what should we do with it? Get rid of it? Refactor and resuse?


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message