hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Igal Shilman (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-6071) getRegionServerWithRetires, should log unsuccessful attempts and exceptions.
Date Sat, 22 Sep 2012 11:57:08 GMT

    [ https://issues.apache.org/jira/browse/HBASE-6071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13461129#comment-13461129

Igal Shilman commented on HBASE-6071:

bq. How much more log does this patch generate Igal? As I read it, it is logging every retry.
>From what we've seen, most of the calls complete within a single attempt, if a retry occurs
then it's pretty much fatal (next attempt is LE), so, in our case, it's up to a single exception
being logged.
I guess folks running long lived clients will see more of these logs. 

bq. we might do something more about it in client?
Maybe log just the abnormal exits?
I mean: If a call eventually succeeds, then failed retries won't be logged,
otherwise we log all the ThrowableWithExtraContext that were accumulated during previous attempts.

for example, a single iteration of withRetries() might look:
try {
        connect(tries != 0);
        return call();
} catch (Throwable t) {
        try {
          handleFailedAttempt(t, numRetries, tries, exceptions);
        } catch (RetriesExhaustedException e) {
          throw e;
        } catch (IOException e) {
          LOG.info("Giving up", new RetriesExhaustedException(numRetries, exceptions));
          throw e;
} finally {

> getRegionServerWithRetires, should log unsuccessful attempts and exceptions.
> ----------------------------------------------------------------------------
>                 Key: HBASE-6071
>                 URL: https://issues.apache.org/jira/browse/HBASE-6071
>             Project: HBase
>          Issue Type: Improvement
>          Components: Client, IPC/RPC
>    Affects Versions: 0.92.0, 0.94.0
>            Reporter: Igal Shilman
>            Priority: Minor
>              Labels: client, ipc
>         Attachments: HBASE-6071.patch, HBASE-6071.v2.patch, HBASE-6071.v3.patch, HBASE-6071.v4.patch,
HConnectionManager_HBASE-6071-0.90.0.patch, lease-exception.txt
> HConnectionImplementation.getRegionServerWithRetries might terminate w/ an exception
different then a DoNotRetryIOException, thus silently drops exceptions from previous attempts.
> [~ted_yu] suggested ([here|http://mail-archives.apache.org/mod_mbox/hbase-user/201205.mbox/%3CCAFebPXBq9V9BVdzRTNr-MB3a1Lz78SZj6gvP6On0b%2Bajt9StAg%40mail.gmail.com%3E])
adding a log message inside the catch block describing the exception type and details.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

View raw message