hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-6317) Master clean start up and Partially enabled tables make region assignment inconsistent.
Date Sat, 15 Sep 2012 04:36:07 GMT

    [ https://issues.apache.org/jira/browse/HBASE-6317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13456311#comment-13456311
] 

Ted Yu commented on HBASE-6317:
-------------------------------

The trunk patch for this issue adds testMasterRestartWhenTableInEnabling.
When I concatenate that test onto Jimmy's patch for HBASE-6776, the test seems to hang:
{code}
"main" prio=10 tid=0x0000000042063800 nid=0x7b4 runnable [0x00007f1033837000]
   java.lang.Thread.State: RUNNABLE
	at org.apache.hadoop.conf.Configuration.getProps(Configuration.java:1061)
	- locked <0x000000008a2a8190> (a org.apache.hadoop.conf.Configuration)
	at org.apache.hadoop.conf.Configuration.get(Configuration.java:416)
	at org.apache.hadoop.conf.Configuration.getLong(Configuration.java:521)
	at org.apache.hadoop.hbase.client.ServerCallable.withRetries(ServerCallable.java:158)
	at org.apache.hadoop.hbase.client.ClientScanner.next(ClientScanner.java:281)
	at org.apache.hadoop.hbase.catalog.MetaReader.fullScan(MetaReader.java:570)
	at org.apache.hadoop.hbase.catalog.MetaReader.getTableRegionsAndLocations(MetaReader.java:491)
	at org.apache.hadoop.hbase.catalog.MetaReader.getTableRegions(MetaReader.java:369)
	at org.apache.hadoop.hbase.master.handler.EnableTableHandler.handleEnableTable(EnableTableHandler.java:127)
	at org.apache.hadoop.hbase.master.handler.EnableTableHandler.process(EnableTableHandler.java:106)
	at org.apache.hadoop.hbase.master.AssignmentManager.recoverTableInEnablingState(AssignmentManager.java:2558)
	at org.apache.hadoop.hbase.master.AssignmentManager.joinCluster(AssignmentManager.java:340)
	at org.apache.hadoop.hbase.master.TestAssignmentManager.testMasterRestartWhenTableInEnabling(TestAssignmentManager.java:888)
{code}
So this issue is not entirely covered by HBASE-6776
                
> Master clean start up and Partially enabled tables make region assignment inconsistent.
> ---------------------------------------------------------------------------------------
>
>                 Key: HBASE-6317
>                 URL: https://issues.apache.org/jira/browse/HBASE-6317
>             Project: HBase
>          Issue Type: Bug
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: rajeshbabu
>             Fix For: 0.96.0, 0.92.3, 0.94.3
>
>         Attachments: HBASE-6317_94_3.patch, HBASE-6317_94.patch, HBASE-6317_trunk_2.patch
>
>
> If we have a  table in partially enabled state (ENABLING) then on HMaster restart we
treat it as a clean cluster start up and do a bulk assign.  Currently in 0.94 bulk assign
will not handle ALREADY_OPENED scenarios and it leads to region assignment problems.  Analysing
more on this we found that we have better way to handle these scenarios.
> {code}
> if (false == checkIfRegionBelongsToDisabled(regionInfo)
>             && false == checkIfRegionsBelongsToEnabling(regionInfo)) {
>           synchronized (this.regions) {
>             regions.put(regionInfo, regionLocation);
>             addToServers(regionLocation, regionInfo);
>           }
> {code}
> We dont add to regions map so that enable table handler can handle it.  But as nothing
is added to regions map we think it as a clean cluster start up.
> Will come up with a patch tomorrow.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message