hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Himanshu Vashishtha (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-6870) HTable#coprocessorExec always scan the whole table
Date Tue, 25 Sep 2012 17:48:08 GMT

    [ https://issues.apache.org/jira/browse/HBASE-6870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13463031#comment-13463031
] 

Himanshu Vashishtha commented on HBASE-6870:
--------------------------------------------

Looked at the patch:

Can you make the these two if statements in-line
{code}
+        if (Bytes.compareTo(start, startKeys[i]) >= 0) {
+          if (Bytes.equals(endKeys[i], HConstants.EMPTY_END_ROW)
+              || Bytes.compareTo(start, endKeys[i]) < 0) {
+            rangeKeys.add(start);
+          }
{code}

Can it be private?
{code}
+  public LinkedHashMap<byte[], HRegionLocation> getKeysToRegionsInRange(
{code}

Re: Andrew's concern regarding cache use: 6877 will take care of region move too? cache may
become stale for reasons other than splits too. Will look at 6877.
                
> HTable#coprocessorExec always scan the whole table 
> ---------------------------------------------------
>
>                 Key: HBASE-6870
>                 URL: https://issues.apache.org/jira/browse/HBASE-6870
>             Project: HBase
>          Issue Type: Improvement
>          Components: Coprocessors
>    Affects Versions: 0.94.1
>            Reporter: chunhui shen
>            Assignee: chunhui shen
>         Attachments: HBASE-6870.patch, HBASE-6870-testPerformance.patch, HBASE-6870v2.patch,
HBASE-6870v3.patch
>
>
> In current logic, HTable#coprocessorExec always scan the whole table, its efficiency
is low and will affect the Regionserver carrying .META. under large coprocessorExec requests

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message