hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-6755) HRegion.internalObtainRowLock uses unecessary AtomicInteger
Date Tue, 11 Sep 2012 03:54:07 GMT

    [ https://issues.apache.org/jira/browse/HBASE-6755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13452695#comment-13452695

stack commented on HBASE-6755:

That random stuff jumping elsewhere looks kinda dodgy?  I wonder why we can't go around in
the loop again?  The variable id name should change?  Its not a generator?  Should the data
member be volatile so the increment is seen immediately (I suppose we're almost back at an
AtomicInteger cost then?

Sorry for raining on simple change...
> HRegion.internalObtainRowLock uses unecessary AtomicInteger
> -----------------------------------------------------------
>                 Key: HBASE-6755
>                 URL: https://issues.apache.org/jira/browse/HBASE-6755
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Lars Hofhansl
>            Assignee: Lars Hofhansl
>             Fix For: 0.96.0, 0.94.2
>         Attachments: 6755-0.96.txt
> I was looking at HBase's implementation of locks and saw that is unnecessarily uses an
AtomicInteger to obtain a unique lockid.
> The observation is that we only need a unique one and don't care if we happen to skip
> In a very unscientific test I saw the %system CPU reduced when the AtomicInteger is avoided.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

View raw message