hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-5448) Support for dynamic coprocessor endpoints with PB-based RPC
Date Tue, 11 Sep 2012 03:44:08 GMT

    [ https://issues.apache.org/jira/browse/HBASE-5448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13452693#comment-13452693
] 

stack commented on HBASE-5448:
------------------------------

Good on you Gary (Was afraid to ask about this one....its gnarly).

bq. I debated for a while ...But it seems simpler to actually embrace that aspect of the generated
code and pass through any provided RpcController where possible.

Sounds reasonable G.

bq.  I created an o.a.h.h.ipc.ServerRpcController implementation to handle the RegionCoprocessorHost
endpoint invocations. This facilitates passing back exceptions to the RPC server.

... should that be back to the client in the above or do you mean passing exceptions from
client to server?

bq. ... but it may make sense to genericize this a bit more and allow clients to make use
of the same implementation.

Same rpccontroller for dynamic cp endpoints or you mean in general (Sorry if dumb question
-- I don't know what the rpccontroller thing is about.. need to go read up).

The bit of code pasted looks reasonable (I was going to say 'natural' but that'd be going
too far... I think you know what I mean... when folks see a pb service, they know they got
some building to do....)

Implementors will be going directly against the pb messages.  Thats probably fine.  If important
to them, they can do the work hiding the pb and doing the transforms in layers of their own.

On #1, above, that means we can't just drop Writable in the rpc for 0.96 because you are thinking
of supporting old and new in 0.96?  (0.96 is the singularity; unless someone screams otherwise,
we can do stuff we wouldn't ever do over a major release -- I should go back to the dev list
and make sure we are all good w/ this... but that is my understanding).

On new issues for convertion of old cp-based implementations, that sounds good.

Let me take a look at the patch now....









                
> Support for dynamic coprocessor endpoints with PB-based RPC
> -----------------------------------------------------------
>
>                 Key: HBASE-5448
>                 URL: https://issues.apache.org/jira/browse/HBASE-5448
>             Project: HBase
>          Issue Type: Sub-task
>          Components: ipc, master, migration, regionserver
>            Reporter: Todd Lipcon
>            Assignee: Gary Helmling
>         Attachments: HBASE-5448.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message