hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jesse Yates (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-6707) TEST org.apache.hadoop.hbase.backup.example.TestZooKeeperTableArchiveClient.testMultipleTables flaps
Date Fri, 28 Sep 2012 22:27:08 GMT

    [ https://issues.apache.org/jira/browse/HBASE-6707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13465959#comment-13465959
] 

Jesse Yates commented on HBASE-6707:
------------------------------------

bq. I think writing rows with different row keys is desirable. The closer the test case is
to real usage, the higher confidence we have for this feature.

Why? The real use case here is to not delete hfiles based on the zookeeper initiated update
the the cleaner.  Seems like it covers it. I'd argue that it even covers the case even if
I didn't use an hregion, but just put files in the archive in the right directories - this
way is just gravy (and little future proofing).


bq. Putting up patch on review board would facilitate review comments.

Added review here: https://reviews.apache.org/r/7344/
                
> TEST org.apache.hadoop.hbase.backup.example.TestZooKeeperTableArchiveClient.testMultipleTables
flaps
> ----------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-6707
>                 URL: https://issues.apache.org/jira/browse/HBASE-6707
>             Project: HBase
>          Issue Type: Bug
>          Components: test
>            Reporter: Sameer Vaishampayan
>            Assignee: Jesse Yates
>            Priority: Critical
>             Fix For: 0.96.0
>
>         Attachments: hbase-6707-v0.patch, hbase-6707-v1.patch, hbase-6707-v2.patch, hbase-6707-v3.patch
>
>
> https://builds.apache.org/job/HBase-TRUNK/3293/
> Error Message
> Archived HFiles (hdfs://localhost:59986/user/jenkins/hbase/.archive/otherTable/01ced3b55d7220a9c460273a4a57b198/fam)
should have gotten deleted, but didn't, remaining files:[hdfs://localhost:59986/user/jenkins/hbase/.archive/otherTable/01ced3b55d7220a9c460273a4a57b198/fam/fc872572a1f5443eb55b6e2567cfeb1c]
> Stacktrace
> java.lang.AssertionError: Archived HFiles (hdfs://localhost:59986/user/jenkins/hbase/.archive/otherTable/01ced3b55d7220a9c460273a4a57b198/fam)
should have gotten deleted, but didn't, remaining files:[hdfs://localhost:59986/user/jenkins/hbase/.archive/otherTable/01ced3b55d7220a9c460273a4a57b198/fam/fc872572a1f5443eb55b6e2567cfeb1c]
> 	at org.junit.Assert.fail(Assert.java:93)
> 	at org.junit.Assert.assertTrue(Assert.java:43)
> 	at org.junit.Assert.assertNull(Assert.java:551)
> 	at org.apache.hadoop.hbase.backup.example.TestZooKeeperTableArchiveClient.testMultipleTables(TestZooKeeperTableArchiveClient.java:291)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
> 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message