hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jesse Yates (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-6439) Ignore .archive directory as a table
Date Thu, 27 Sep 2012 19:21:08 GMT

    [ https://issues.apache.org/jira/browse/HBASE-6439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13465002#comment-13465002
] 

Jesse Yates commented on HBASE-6439:
------------------------------------

yeah, it was configurable, but stack was saying that we should just make .archive the directory
we always archive files. This patch then becomes the removal of the configuration element,
fixing all the places it looks in the conf for archive directory (more that getStoreArchivePath,
but not too many places), adding a constant value for the .archive directory and then, finally,
updating the non-table-dirs constant.

Make sense?
                
> Ignore .archive directory as a table
> ------------------------------------
>
>                 Key: HBASE-6439
>                 URL: https://issues.apache.org/jira/browse/HBASE-6439
>             Project: HBase
>          Issue Type: Bug
>          Components: io, regionserver
>    Affects Versions: 0.96.0
>            Reporter: Jesse Yates
>            Assignee: Sameer Vaishampayan
>              Labels: newbie
>
> From a recent test run:
> {quote}
> 2012-07-22 02:27:30,699 WARN  [IPC Server handler 0 on 47087] util.FSTableDescriptors(168):
The following folder is in HBase's root directory and doesn't contain a table descriptor,
do consider deleting it: .archive
> {quote}
> With the addition of HBASE-5547, table-level folders are no-longer all table folders.
FSTableDescriptors needs to then have a 'gold-list' that we can update with directories that
aren't tables so we don't have this kind of thing showing up in the logs.
> Currently, we have the following block:
> {quote}
>     invocations++;
>     if (HTableDescriptor.ROOT_TABLEDESC.getNameAsString().equals(tablename)) {
>       cachehits++;
>       return HTableDescriptor.ROOT_TABLEDESC;
>     }
>     if (HTableDescriptor.META_TABLEDESC.getNameAsString().equals(tablename)) {
>       cachehits++;
>       return HTableDescriptor.META_TABLEDESC;
>     }
> {quote}
> to handle special cases, but that's a bit clunky and not clean in terms of table-level
directories that need to be ignored.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message