hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-6900) RegionScanner.reseek() creates NPE when a flush or compaction happens before the reseek.
Date Sun, 30 Sep 2012 17:58:08 GMT

    [ https://issues.apache.org/jira/browse/HBASE-6900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13466532#comment-13466532
] 

Hadoop QA commented on HBASE-6900:
----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12547166/HBASE-6900_1.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 3 new or modified
tests.

    {color:green}+1 hadoop2.0{color}.  The patch compiles against the hadoop 2.0 profile.

    {color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 149 warning
messages.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of
javac compiler warnings.

    {color:red}-1 findbugs{color}.  The patch appears to introduce 7 new Findbugs (version
1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2973//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2973//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2973//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2973//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2973//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2973//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2973//console

This message is automatically generated.
                
> RegionScanner.reseek() creates NPE when a flush or compaction happens before the reseek.
> ----------------------------------------------------------------------------------------
>
>                 Key: HBASE-6900
>                 URL: https://issues.apache.org/jira/browse/HBASE-6900
>             Project: HBase
>          Issue Type: Bug
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>         Attachments: HBASE-6900_1.patch, HBASE-6900.patch
>
>
> HBASE-5520 introduced reseek() on the RegionScanner.  
> Now when a scanner is created we have the StoreScanner heap.  After this if a flush or
compaction happens parallely all the StoreScannerObservers are cleared so that whenever a
new next() call happens we tend to recreate the scanner based on the latest store files.
> The reseek() in StoreScanner expects the heap not to be null because always reseek would
be called from next()
> {code}
> public synchronized boolean reseek(KeyValue kv) throws IOException {
>     //Heap cannot be null, because this is only called from next() which
>     //guarantees that heap will never be null before this call.
>     if (explicitColumnQuery && lazySeekEnabledGlobally) {
>       return heap.requestSeek(kv, true, useRowColBloom);
>     } else {
>       return heap.reseek(kv);
>     }
>   }
> {code}
> Now when we call RegionScanner.reseek() directly using CPs we tend to get a NPE.  In
our case it happened when a major compaction was going on.  I will also attach a testcase
to show the problem.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message