hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matteo Bertozzi (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-6055) Snapshots in HBase 0.96
Date Wed, 26 Sep 2012 10:44:11 GMT

    [ https://issues.apache.org/jira/browse/HBASE-6055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13463700#comment-13463700

Matteo Bertozzi commented on HBASE-6055:

When you're talking about hfiles, you are referring to the log files right? I've a bit a of
confusion reading your comment, bacause the log files are sequence files. anyway...

The logs in /hbase/.logs are splitted (new files are created in region/recover.edits) and
if you look at HRegion.replayRecoveredEditsIfAny(), the content of recover.edits is removed
as soon as the edits are applied. Removed, not archived. And this means that as soon as the
table goes online, the snapshot doesn't have a way to read those files.

but as you've said, the original (full) log is still available during split, but moved to
the archive (.oldlogs) as soon as the split is done. 

This means that if you see files in recover.edits, you should have the full logs in /hbase/.logs
folder. And you can keep a reference to them, as you do for the online snapshot.

Another semi-unrelated note... currently we keep full logs files, and the restore needs to
split them (see the restore code SnapshotLogSplitter, https://github.com/matteobertozzi/hbase/blob/snapshot-dev/hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/restore/RestoreSnapshotHelper.java#L398)
Can we move this logic at the end of the take snapshot operation and split the logs in .snapshot/region/recover.edits?
> Snapshots in HBase 0.96
> -----------------------
>                 Key: HBASE-6055
>                 URL: https://issues.apache.org/jira/browse/HBASE-6055
>             Project: HBase
>          Issue Type: New Feature
>          Components: Client, master, regionserver, snapshots, Zookeeper
>            Reporter: Jesse Yates
>            Assignee: Jesse Yates
>             Fix For: hbase-6055, 0.96.0
>         Attachments: Snapshots in HBase.docx
> Continuation of HBASE-50 for the current trunk. Since the implementation has drastically
changed, opening as a new ticket.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

View raw message