hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jie Huang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-5631) hbck should handle case where .tableinfo file is missing.
Date Mon, 10 Sep 2012 00:55:07 GMT

    [ https://issues.apache.org/jira/browse/HBASE-5631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13451721#comment-13451721
] 

Jie Huang commented on HBASE-5631:
----------------------------------

bq. I noticed one thing as I was committing – we don't actually test the non-cached tableinfo
fabrication path. File a follow-on issue for that?

I have tested the non-cached case as well. see following lines
{code}
+      
+      // fix OrphanTable with default .tableinfo << non-cached case here
+      hbck = doFsck(conf, true);
+      assertNoErrors(hbck);
+      status = null;
+      status = FSTableDescriptors.getTableInfoPath(fs, hbaseTableDir);
+      assertNotNull(status);
+      
+      HTableDescriptor htd = admin.getTableDescriptor(table.getBytes());
+      htd.setValue("NOT_DEFAULT", "true");
+      admin.disableTable(table);
+      admin.modifyTable(table.getBytes(), htd);
+      admin.enableTable(table);
+      fs.delete(status.getPath(), true);
+      
+      // fix OrphanTable with cache << cached case here
+      htd = admin.getTableDescriptor(table.getBytes());
+      hbck = doFsck(conf, true);
+      assertNoErrors(hbck);
+      status = null;
+      status = FSTableDescriptors.getTableInfoPath(fs, hbaseTableDir);
+      assertNotNull(status);
+      htd = admin.getTableDescriptor(table.getBytes());
+      assertEquals(htd.getValue("NOT_DEFAULT"), "true");
{code}
                
> hbck should handle case where .tableinfo file is missing.
> ---------------------------------------------------------
>
>                 Key: HBASE-5631
>                 URL: https://issues.apache.org/jira/browse/HBASE-5631
>             Project: HBase
>          Issue Type: Improvement
>          Components: hbck
>    Affects Versions: 0.92.2, 0.94.0, 0.96.0
>            Reporter: Jonathan Hsieh
>            Assignee: Jie Huang
>             Fix For: 0.96.0, 0.92.3, 0.94.2
>
>         Attachments: hbase-5631.patch, hbase-5631-v1.patch, hbase-5631-v2.patch
>
>
> 0.92+ branches have a .tableinfo file which could be missing from hdfs.  hbck should
be able to detect and repair this properly.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message