Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Tue, 21 Aug 2012 03:13:37 +1100 (NCT)
From: "Zhihong Ted Yu (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <918440027.30434.1345479217892.JavaMail.jiratomcat@arcas>
In-Reply-To: <76611160.12676.1345030058182.JavaMail.jiratomcat@arcas>
Subject: [jira] [Commented] (HBASE-6588) enable table throws npe and leaves
 trash in zk in competition with delete table
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-6588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13437972#comment-13437972 ] 

Zhihong Ted Yu commented on HBASE-6588:
---------------------------------------

For patch v5, if you look at https://builds.apache.org/job/PreCommit-HBASE-Build/2623/console, you can see that compilation failed for hadoop 2.0 profile.
I got the following error compiling against hadoop 2.0, locally:
{code}
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:2.0.2:compile (default-compile) on project hbase-server: Compilation failure: Compilation failure:
[ERROR] /home/zhihyu/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java:[722,50] cannot find symbol
[ERROR] symbol  : variable COMPACTION_KV_MAX
[ERROR] location: class org.apache.hadoop.hbase.HConstants
[ERROR] 
[ERROR] /home/zhihyu/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java:[3578,36] cannot find symbol
[ERROR] symbol  : method isInternal()
[ERROR] location: class org.apache.hadoop.hbase.KeyValue
[ERROR] 
[ERROR] /home/zhihyu/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/Compactor.java:[113,53] cannot find symbol
[ERROR] symbol  : variable COMPACTION_KV_MAX
[ERROR] location: class org.apache.hadoop.hbase.HConstants
{code}
                
> enable table throws npe and leaves trash in zk in competition with delete table
> -------------------------------------------------------------------------------
>
>                 Key: HBASE-6588
>                 URL: https://issues.apache.org/jira/browse/HBASE-6588
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.94.0
>            Reporter: Zhou wenjian
>            Assignee: Zhou wenjian
>             Fix For: 0.94.2
>
>         Attachments: HBASE-6588-trunk.patch, HBASE-6588-trunk-v2.patch, HBASE-6588-trunk-v3.patch, HBASE-6588-trunk-v4.patch, HBASE-6588-trunk-v5.patch
>
>
> 2012-08-15 19:23:36,178 DEBUG org.apache.hadoop.hbase.client.ClientScanner: Creating scanner over .META. starting at key 'test,,'
> 2012-08-15 19:23:36,178 DEBUG org.apache.hadoop.hbase.client.ClientScanner: Advancing internal scanner to startKey at 'test,,'
> 2012-08-15 19:24:09,180 DEBUG org.apache.hadoop.hbase.client.ClientScanner: Creating scanner over .META. starting at key ''
> 2012-08-15 19:24:09,180 DEBUG org.apache.hadoop.hbase.client.ClientScanner: Advancing internal scanner to startKey at ''
> 2012-08-15 19:24:09,183 DEBUG org.apache.hadoop.hbase.client.ClientScanner: Finished with scanning at {NAME => '.META.,,1', STARTKEY => '', ENDKEY => '', ENCODED => 1028785192,}
> 2012-08-15 19:24:09,183 DEBUG org.apache.hadoop.hbase.master.CatalogJanitor: Scanned 2 catalog row(s) and gc'd 0 unreferenced parent region(s)
> 2012-08-15 19:25:12,260 DEBUG org.apache.hadoop.hbase.master.handler.DeleteTableHandler: Deleting region test,,1345029764571.d1e24b251ca6286c840a9a5f571b7db1. from META and FS
> 2012-08-15 19:25:12,263 INFO org.apache.hadoop.hbase.catalog.MetaEditor: Deleted region test,,1345029764571.d1e24b251ca6286c840a9a5f571b7db1. from META
> 2012-08-15 19:25:12,265 INFO org.apache.hadoop.hbase.master.handler.EnableTableHandler: Attemping to enable the table test
> 2012-08-15 19:25:12,265 WARN org.apache.hadoop.hbase.zookeeper.ZKTable: Moving table test state to enabling but was not first in disabled state: null
> 2012-08-15 19:25:12,267 DEBUG org.apache.hadoop.hbase.client.ClientScanner: Creating scanner over .META. starting at key 'test,,'
> 2012-08-15 19:25:12,267 DEBUG org.apache.hadoop.hbase.client.ClientScanner: Advancing internal scanner to startKey at 'test,,'
> 2012-08-15 19:25:12,270 DEBUG org.apache.hadoop.hbase.client.ClientScanner: Finished with scanning at {NAME => '.META.,,1', STARTKEY => '', ENDKEY => '', ENCODED => 1028785192,}
> 2012-08-15 19:25:12,270 ERROR org.apache.hadoop.hbase.executor.EventHandler: Caught throwable while processing event C_M_ENABLE_TABLE
> java.lang.NullPointerException
>         at org.apache.hadoop.hbase.master.handler.EnableTableHandler.handleEnableTable(EnableTableHandler.java:116)
>         at org.apache.hadoop.hbase.master.handler.EnableTableHandler.process(EnableTableHandler.java:97)
>         at org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:169)
>         at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
>         at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
>         at java.lang.Thread.run(Thread.java:662)
> table is disabled now, then we enable and delete the table at the same time. 
> Since the thread num of MASTER_TABLE_OPERATIONS is 1 by default. The two operations are serial in master.Before deletetable deletes all the regions in meta, CreateTableHandler ships the check of tableExists,then it will block until deletetable finishs, then CreateTableHandler will set zk enabling, and find no data in meta:
>  regionsInMeta = MetaReader.getTableRegions(this.ct, tableName, true);
>  int countOfRegionsInTable = regionsInMeta.size();
> npe will be throwed here. And we could not create the same table anymore.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira