Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Sat, 18 Aug 2012 04:02:38 +1100 (NCT)
From: "stack (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <738962417.24144.1345222958063.JavaMail.jiratomcat@arcas>
In-Reply-To: <1223601329.4056.1344892838106.JavaMail.jiratomcat@arcas>
Subject: [jira] [Commented] (HBASE-6568) Extract daemon thread factory from
 HTable into its own class
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-6568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13436868#comment-13436868 ] 

stack commented on HBASE-6568:
------------------------------

bq. How about we backport to 0.94 and close this and then do a new jira to move to common module and/or move package?

Yes.

It should be in util, not at top level.  That should be fixed (the addendum applied?)  Why not put it into our general Threads util class altogether?  Thats where I'd look when looking for thready stuff -- it has method returning a factory currently).

It looks like the manufactored threads do not follow current thread naming conventions either where thread source is prefix on name, etc. (Why would you have -thread- in the name of a thread?)

I'd say revert this patch as is if only for fact that its not in util (it could be in client too if that is only user... later could be moved elsewhere if someone else wanted use it).


> Extract daemon thread factory from HTable into its own class
> ------------------------------------------------------------
>
>                 Key: HBASE-6568
>                 URL: https://issues.apache.org/jira/browse/HBASE-6568
>             Project: HBase
>          Issue Type: Sub-task
>    Affects Versions: 0.96.0
>            Reporter: Jesse Yates
>            Assignee: Jesse Yates
>             Fix For: 0.96.0
>
>         Attachments: hbase-6568-addendum.patch, java_HBASE-6568-v0.patch
>
>
> The DaemonThreadFactory in HTable is a really nice utility that is useful in multiple places. We should pull out into a standalone class.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira