Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Sat, 1 Sep 2012 08:23:07 +1100 (NCT)
From: "Hadoop QA (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <1898083217.24987.1346448187930.JavaMail.jiratomcat@arcas>
In-Reply-To: <97081069.42803.1342114054833.JavaMail.jiratomcat@issues-vm>
Subject: [jira] [Commented] (HBASE-6381) AssignmentManager should use the
 same logic for clean startup and failover
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-6381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13446390#comment-13446390 ] 

Hadoop QA commented on HBASE-6381:
----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12543340/hbase-6381.pdf
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    -1 patch.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2757//console

This message is automatically generated.
                
> AssignmentManager should use the same logic for clean startup and failover
> --------------------------------------------------------------------------
>
>                 Key: HBASE-6381
>                 URL: https://issues.apache.org/jira/browse/HBASE-6381
>             Project: HBase
>          Issue Type: Bug
>          Components: master
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>         Attachments: hbase-6381-notes.pdf, hbase-6381.pdf, trunk-6381_v5.patch
>
>
> Currently AssignmentManager handles clean startup and failover very differently.
> Different logic is mingled together so it is hard to find out which is for which.
> We should clean it up and share the same logic so that AssignmentManager handles
> both cases the same way.  This way, the code will much easier to understand and
> maintain.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira