hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-6481) SkipFilter javadoc is incorrect
Date Fri, 03 Aug 2012 23:42:02 GMT

    [ https://issues.apache.org/jira/browse/HBASE-6481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13428469#comment-13428469
] 

Hudson commented on HBASE-6481:
-------------------------------

Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #120 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/120/])
    HBASE-6481 SkipFilter javadoc is incorrect (Shrijeet) (Revision 1369027)

     Result = FAILURE
tedyu : 
Files : 
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/filter/SkipFilter.java

                
> SkipFilter javadoc is incorrect
> -------------------------------
>
>                 Key: HBASE-6481
>                 URL: https://issues.apache.org/jira/browse/HBASE-6481
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.94.0
>            Reporter: Shrijeet Paliwal
>            Priority: Minor
>              Labels: newbie
>             Fix For: 0.96.0
>
>         Attachments: 0001-HBASE-6481-SkipFilter-javadoc-is-incorrect.patch
>
>
> The javadoc for SkipFilter (http://hbase.apache.org/apidocs/org/apache/hadoop/hbase/filter/SkipFilter.html)
states : 
>  
> A wrapper filter that filters an entire row if any of the KeyValue checks do not pass.
>  
> But the example same javadocs gives to support this statement is wrong. The *scan.setFilter(new
SkipFilter(new ValueFilter(CompareOp.EQUAL,
>      new BinaryComparator(Bytes.toBytes(0))));* , will only emit rows which have all
column values zero. In other words it is going to skip all rows for which 
> ValueFilter(CompareOp.EQUAL, new BinaryComparator(Bytes.toBytes(0))) does not pass ,
which happen to be all non zero valued cells. 
> In the same example a ValueFilter created with CompareOp.NOT_EQUAL will filter out the
rows which have a column value zero. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message