hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zhihong Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-6414) Remove the WritableRpcEngine & associated Invocation classes
Date Mon, 06 Aug 2012 02:20:02 GMT

    [ https://issues.apache.org/jira/browse/HBASE-6414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13428957#comment-13428957
] 

Zhihong Ted Yu commented on HBASE-6414:
---------------------------------------

{code}
+          if (builder.mergeDelimitedFrom(in)) {
+            value = builder.build();
+          }
{code}
Should there be an else block for the above if ?
{code}
+      } catch (Exception e) {
+        // TODO Auto-generated catch block
+        e.printStackTrace();
{code}
Should something similar to closeException be introduced to save the caught exception ?

There're a few white spaces, visible if you put the patch on review board.
                
> Remove the WritableRpcEngine & associated Invocation classes
> ------------------------------------------------------------
>
>                 Key: HBASE-6414
>                 URL: https://issues.apache.org/jira/browse/HBASE-6414
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 0.96.0
>            Reporter: Devaraj Das
>            Assignee: Devaraj Das
>             Fix For: 0.96.0
>
>         Attachments: 6414-initial.patch.txt, 6414-initial.patch.txt
>
>
> Remove the WritableRpcEngine & Invocation classes once HBASE-5705 gets committed
and all the protocols are rebased to use PB.
> Raising this jira in advance..

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message