hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matt Corgan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-6234) Move simple KeyValue tests to hbase-common module
Date Thu, 30 Aug 2012 23:15:08 GMT

    [ https://issues.apache.org/jira/browse/HBASE-6234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13445413#comment-13445413
] 

Matt Corgan commented on HBASE-6234:
------------------------------------

Sorry - it's been a couple months so i forgot the reasoning behind these things.  The problem
is that ResourceCheckerJUnitRule depends on ResourceChecker, which depends on HConnectionTestingUtility,
which depends on a bunch of things like HRegionInfo... quick guess is that we should eventually
cut the cord between ResourceChecker and HConnectionTestingUtility, but i'll have to punt
that to another jira.

Do you think it's ok to drop it for now NK so we can pull up the other stuff?  I don't really
have an opinion since i don't know what it does (any better than a guess).  I will submit
the patch without it since i already made it.
                
> Move simple KeyValue tests to hbase-common module
> -------------------------------------------------
>
>                 Key: HBASE-6234
>                 URL: https://issues.apache.org/jira/browse/HBASE-6234
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 0.96.0
>            Reporter: Matt Corgan
>            Assignee: Matt Corgan
>         Attachments: HBASE-6234-v1.patch
>
>
> TestKeyValue, LoadTestKVGenerator, and TestLoadTestKVGenerator should move up to hbase-common.
 This brings MD5Hash up as a dependency as well.
> To play well with Maven as discussed in HBASE-6162, I moved LoadTestKVGenerator from
the src/test folder to src/main folder so that tests in other modules can see it.  A couple
other files' import statements were affected by this.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message