hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-6689) HRegion.increment comment nits
Date Fri, 31 Aug 2012 03:55:11 GMT

    [ https://issues.apache.org/jira/browse/HBASE-6689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13445612#comment-13445612
] 

Hudson commented on HBASE-6689:
-------------------------------

Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #155 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/155/])
    HBASE-6689 HRegion.increment comment nits (Revision 1379152)

     Result = FAILURE
stack : 
Files : 
* /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
* /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java

                
> HRegion.increment comment nits
> ------------------------------
>
>                 Key: HBASE-6689
>                 URL: https://issues.apache.org/jira/browse/HBASE-6689
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Gregory Chanan
>            Assignee: Gregory Chanan
>            Priority: Trivial
>             Fix For: 0.96.0
>
>         Attachments: HBASE-6689.patch
>
>
> Just a couple of trivial nits with the comments in this area of code:
> - In the test, a thread is called reader when it never actually reads, just flushes
> - The WAL edits are prepared per column family, then the WAL is written once all the
column families have been checked.  But the comment says "// Append update to WAL" (as if
it were being written) when the edits are just being prepared on a single column family.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message