hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-6412) Move external servers to metrics2 (thrift,thrift2,rest)
Date Tue, 28 Aug 2012 05:44:08 GMT

    [ https://issues.apache.org/jira/browse/HBASE-6412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13442971#comment-13442971
] 

stack commented on HBASE-6412:
------------------------------

Missing licenses.

Why is it called a CompatibilityFactory?  Thats pretty generic.  Is it indeed compatibility
for all things (It looks like it could be 'generic')?

Is it good having 'Singleton' in name of a class?  CompatibilitySingletonFactory.  Is it good
having Singleton's in HBase?  It'll be ok when we have a bunch of servers afloat in the one
JVM?  Is there only one instance shared by all?

The metrics source Interfaces look good.

What is a MetricsAssertHelper?  Sounds painful!

Is stuff that is already committed?  Or overlap with other patches?  (Sense of deja vu'ing
here)

Do we have to do the Impl suffix on things like RESTMetricsSourceImpl?  Its inelegant.  It
does get the point across though so I'm not all against it.

This is funny though: ThriftServerMetricsSourceFactoryImpl  Maybe you could get a few more
keywords on the  class name (smile)?

Approach looks good to me Elliott.  Its not possible putting the Interfaces in a base class
used by hadoop 1 and 2 compat because they are so different?







                
> Move external servers to metrics2 (thrift,thrift2,rest)
> -------------------------------------------------------
>
>                 Key: HBASE-6412
>                 URL: https://issues.apache.org/jira/browse/HBASE-6412
>             Project: HBase
>          Issue Type: Sub-task
>    Affects Versions: 0.96.0
>            Reporter: Elliott Clark
>            Assignee: Elliott Clark
>            Priority: Blocker
>         Attachments: HBASE-6412-0.patch
>
>
> Implement metrics2 for all the external servers:
> * Thrift
> * Thrift2
> * Rest

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message