hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Lars Hofhansl (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-6476) Replace all occurrances of System.currentTimeMillis() with EnvironmentEdge equivalent
Date Fri, 03 Aug 2012 19:21:02 GMT

    [ https://issues.apache.org/jira/browse/HBASE-6476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13428308#comment-13428308
] 

Lars Hofhansl commented on HBASE-6476:
--------------------------------------

The test is unrelated. I searched the generated findbugs warning for "EnvironmentEdge" and
did not find anything.
So I think this is good to go. If there are no objections I'll commit this soon. (Then I'll
need some help added the build task to check for these, but according to @nkeyval that should
be simple).
                
> Replace all occurrances of System.currentTimeMillis() with EnvironmentEdge equivalent
> -------------------------------------------------------------------------------------
>
>                 Key: HBASE-6476
>                 URL: https://issues.apache.org/jira/browse/HBASE-6476
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Lars Hofhansl
>            Assignee: Lars Hofhansl
>            Priority: Minor
>             Fix For: 0.96.0
>
>         Attachments: 6476-v2.txt, 6476-v2.txt, 6476.txt
>
>
> There are still some areas where System.currentTimeMillis() is used in HBase. In order
to make all parts of the code base testable and (potentially) to be able to configure HBase's
notion of time, this should be generally be replaced with EnvironmentEdgeManager.currentTimeMillis().
> How hard would it be to add a maven task that checks for that, so we do not introduce
System.currentTimeMillis back in the future?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message