hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-6659) Port HBASE-6508 Filter out edits at log split time
Date Fri, 31 Aug 2012 17:21:07 GMT

    [ https://issues.apache.org/jira/browse/HBASE-6659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13446142#comment-13446142
] 

Ted Yu commented on HBASE-6659:
-------------------------------

bq. Do we not have the methods getRegionsByServer in HBaseTestingUtility already
'In HBaseTestingUtility, I don't see getRegionsByServer()' was for above comment.
bq. You can pass null to the first IIRC... at least the second should call the first.
bq. you're right that flushRegion(final RpcController controller, final FlushRegionRequest
request) requires the composition of FlushRegionRequest.
I will remove flushRegion(byte[] regionName) method and replace the call with one to the existing
method.
bq. There is at least AM#regions
I searched AssignmentManager and don't see regions field.

w.r.t. adding updateLastFlushedSequenceIds(), the current formation of the patch is due to
the fact that regionServerReport() is in ServerManager. ServerManager is marked @InterfaceAudience.Private,
so ServerManager needs to deliver status update to HMaster.

bq. Could we put the rpc behind an Interface at least?
To my understanding, RegionServerStatusProtocol is an interface:
{code}
public interface RegionServerStatusProtocol extends
{code}
Will upload new patch.
                
> Port HBASE-6508 Filter out edits at log split time
> --------------------------------------------------
>
>                 Key: HBASE-6659
>                 URL: https://issues.apache.org/jira/browse/HBASE-6659
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Zhihong Ted Yu
>            Assignee: Zhihong Ted Yu
>             Fix For: 0.96.0
>
>         Attachments: 6508-v2.txt, 6508-v3.txt, 6508-v4.txt, 6508-v5.txt, 6508-v6.txt
>
>
> HBASE-6508 is for 0.89-fb branch.
> This JIRA ports the feature to trunk.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message