hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zhihong Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-5937) Refactor HLog into an interface.
Date Tue, 14 Aug 2012 16:40:38 GMT

    [ https://issues.apache.org/jira/browse/HBASE-5937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13434247#comment-13434247
] 

Zhihong Ted Yu commented on HBASE-5937:
---------------------------------------

Thanks Flavio and Ivan for tackling this issue.

w.r.t. reader / writer creation, we can leave them in HLogUtil for now. They don't belong
to FSHLog or HLogFactory.

For HLog interface, please add javadoc for each of its methods.
{code}
    public interface Reader {
        void init(FileSystem fs, Path path, Configuration c) throws IOException;
{code}
If HLog.Reader is FileSystem backed, I would assume that HLog is backed by FileSystem as well.
Can we declare the first parameter as Object ?
FSHLog can declare FSReader which extends HLog.Reader that casts first parameter from init()
as FileSystem.

Please tell us which tests fail so that other people can help.
                
> Refactor HLog into an interface.
> --------------------------------
>
>                 Key: HBASE-5937
>                 URL: https://issues.apache.org/jira/browse/HBASE-5937
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Li Pi
>            Assignee: Li Pi
>            Priority: Minor
>
> What the summary says. Create HLog interface. Make current implementation use it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message