hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-3925) Make Shell's -d and debug cmd behave the same
Date Wed, 29 Aug 2012 01:57:07 GMT

    [ https://issues.apache.org/jira/browse/HBASE-3925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13443741#comment-13443741
] 

Hadoop QA commented on HBASE-3925:
----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12542735/HBASE-3925.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    -1 patch.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2723//console

This message is automatically generated.
                
> Make Shell's -d and debug cmd behave the same
> ---------------------------------------------
>
>                 Key: HBASE-3925
>                 URL: https://issues.apache.org/jira/browse/HBASE-3925
>             Project: HBase
>          Issue Type: Improvement
>          Components: shell
>    Affects Versions: 0.90.3, 0.90.7, 0.92.2, 0.96.0, 0.98.0, 0.94.3
>            Reporter: Lars George
>            Assignee: liang xie
>            Priority: Trivial
>              Labels: patch
>         Attachments: HBASE-3925.patch
>
>
> The -d option switches log4j to DEBUG and leaves the backtrace level at the default.
When using the supplied debug command we only switch the backtrace, but I would think this
also should set the log4j levels:
> {noformat}
> # Debugging method
> def debug
>   if @shell.debug
>     @shell.debug = false
>     conf.back_trace_limit = 0
>   else
>     @shell.debug = true
>     conf.back_trace_limit = 100
>   end
>   debug?
> end
> {noformat}
> could be something like 
> {noformat}
> # Debugging method
> def debug
>   if @shell.debug
>     @shell.debug = false
>     conf.back_trace_limit = 0
>     log_level = org.apache.log4j.Level::ERROR
>   else
>     @shell.debug = true
>     conf.back_trace_limit = 100
>     log_level = org.apache.log4j.Level::DEBUG
>   end
>   org.apache.log4j.Logger.getLogger("org.apache.zookeeper").setLevel(log_level)
>   org.apache.log4j.Logger.getLogger("org.apache.hadoop.hbase").setLevel(log_level)
>   debug?
> end
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message