hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-6234) Move simple KeyValue tests to hbase-common module
Date Fri, 31 Aug 2012 16:52:07 GMT

    [ https://issues.apache.org/jira/browse/HBASE-6234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13446125#comment-13446125
] 

stack commented on HBASE-6234:
------------------------------

[~nkeywal] What if hbase-common did not include these lines but hbase-server and all its dependencies
did.  We could still do thread and file descriptor counts right?  But it'd just be for the
tests that include these lines?  So, we would be losing all-test coverage?  Could we make
it so all tests in hbase-common all run in the one JVM and require that they are all 'small'
as per your categorization?  Would this help contain the damage hbase-common unit tests could
do?  i.e. if in their own jvm, thread leakage or file descriptor counts would impinge little
on other tests run... and if a problem, because all in one jvm, should be easy enough debugging
leakage (you have tools already that could be used here that are other than the lines added
to unit test files?).
                
> Move simple KeyValue tests to hbase-common module
> -------------------------------------------------
>
>                 Key: HBASE-6234
>                 URL: https://issues.apache.org/jira/browse/HBASE-6234
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 0.96.0
>            Reporter: Matt Corgan
>            Assignee: Matt Corgan
>             Fix For: 0.96.0
>
>         Attachments: HBASE-6234-v1.patch, HBASE-6234-v2.patch
>
>
> TestKeyValue, LoadTestKVGenerator, and TestLoadTestKVGenerator should move up to hbase-common.
 This brings MD5Hash up as a dependency as well.
> To play well with Maven as discussed in HBASE-6162, I moved LoadTestKVGenerator from
the src/test folder to src/main folder so that tests in other modules can see it.  A couple
other files' import statements were affected by this.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message