hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Konstantin Shvachko (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-6340) HBase RPC does not allow protocol extension with common interfaces.
Date Tue, 14 Aug 2012 22:55:38 GMT

    [ https://issues.apache.org/jira/browse/HBASE-6340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13434610#comment-13434610
] 

Konstantin Shvachko commented on HBASE-6340:
--------------------------------------------

> -1 javac. The applied patch generated 5 javac compiler warnings (more than the trunk's
current 4 warnings).

Checked Javac warnings. There are the same 4 of them. Looks like Jenkins counted as the fifth
one a warning from hbase-it subproject saying
{code}
[WARNING] The POM for org.apache.hbase:hbase-server:jar:tests:0.95-20120530.180436-1 is invalid
{code}

> -1 findbugs. 

Went over Findbugs Warnings. Did not find any differences to the trunk or any warnings related
to the patch. Not sure how this is counted.

> -1 core tests. 

Tests are flaky. Those three are not related to the patch and succeed if run individually.
                
> HBase RPC does not allow protocol extension with common interfaces.
> -------------------------------------------------------------------
>
>                 Key: HBASE-6340
>                 URL: https://issues.apache.org/jira/browse/HBASE-6340
>             Project: HBase
>          Issue Type: Bug
>          Components: coprocessors, regionserver
>    Affects Versions: 0.92.0
>            Reporter: Konstantin Shvachko
>            Assignee: Konstantin Shvachko
>         Attachments: RPCInvocation.patch
>
>
> HBase RPC fails if MyProtocol extends an interface, which is not a VersionedProtocol
even if MyProtocol also directly extends VersionedProtocol. The reason is that rpc Invocation
uses Method.getDeclaringClass(), which returns the interface class rather than the class of
MyProtocol.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message