hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Flavio Junqueira (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-5937) Refactor HLog into an interface.
Date Tue, 14 Aug 2012 15:29:37 GMT

    [ https://issues.apache.org/jira/browse/HBASE-5937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13434195#comment-13434195
] 

Flavio Junqueira commented on HBASE-5937:
-----------------------------------------

I wanted to report the progress Ivan and I have made on this issue so far. We have a repository
that we have been working on, just in case anyone is interested in giving comments on our
changes so far:

https://github.com/fpj/hbase

Here are some issues we have come across and we have in our todo list:

# Failing tests: There are a number of tests failing and we are still investigating the causes;
# getReader/createWriter: We moved these methods to HLogUtil, but we can't agree on whether
they should be part of the new HLog interface or not. The main issue is that getReader is
called from a number of places where we have no HLog object available. In the case we make
them part of the interface, we will need to find a way of making an HLog object available
in those places.
# HLogSplitter: It should be part of HLogFactory.
# Protected methods of FSHLog: There are a number of calls in the tests to protected methods
of FSHLog. We solved it so far by type-casting, but it doesn't look very clean and I'm not
very happy about that.
                
> Refactor HLog into an interface.
> --------------------------------
>
>                 Key: HBASE-5937
>                 URL: https://issues.apache.org/jira/browse/HBASE-5937
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Li Pi
>            Assignee: Li Pi
>            Priority: Minor
>
> What the summary says. Create HLog interface. Make current implementation use it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message