hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-6659) Port HBASE-6508 Filter out edits at log split time
Date Fri, 31 Aug 2012 14:06:09 GMT

    [ https://issues.apache.org/jira/browse/HBASE-6659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13445962#comment-13445962
] 

Ted Yu commented on HBASE-6659:
-------------------------------

In HBaseTestingUtility, I don't see getRegionsByServer().
TestHLog is a large test. There would be more tests added to TestHLog in the future. According
to N's motto, we should keep runtime for large tests in check. So I keep TestHLogFiltering
for now.
New method getLastFlushedSequenceId() is called by HLogSplitter. The timing of this call is
not in sync with region server heartbeat.
bq. We make a call to the master per region from down inside HLogSplitter to ask for last
known sequence id?
For 'protected final RegionServerStatusProtocol master', I agree there is something to be
desired. Previously there was no need for HLogSplitter to know the actual status for any region
in the WALs it splits. This feature adds this requirement. We can do buffering of calls to
master. But I found that code would get more convoluted that way.

w.r.t. introduction of void flushRegion(byte[] regionName), you're right that flushRegion(final
RpcController controller, final FlushRegionRequest request) requires the composition of FlushRegionRequest.
So that method is called by client.

Will answer the remaining questions.
                
> Port HBASE-6508 Filter out edits at log split time
> --------------------------------------------------
>
>                 Key: HBASE-6659
>                 URL: https://issues.apache.org/jira/browse/HBASE-6659
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Zhihong Ted Yu
>            Assignee: Zhihong Ted Yu
>             Fix For: 0.96.0
>
>         Attachments: 6508-v2.txt, 6508-v3.txt, 6508-v4.txt, 6508-v5.txt
>
>
> HBASE-6508 is for 0.89-fb branch.
> This JIRA ports the feature to trunk.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message