hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jesse Yates (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-6568) Extract daemon thread factory from HTable into its own class
Date Fri, 17 Aug 2012 17:08:37 GMT

    [ https://issues.apache.org/jira/browse/HBASE-6568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13436878#comment-13436878
] 

Jesse Yates commented on HBASE-6568:
------------------------------------

bq.  later could be moved elsewhere if someone else wanted use it

Using it for snapshots (the genesis of this patch) on the server side, so util/common is better
than client.

bq. Why not put it into our general Threads util class altogether? Thats where I'd look when
looking for thready stuff – it has method returning a factory currently.

Nice idea. It'd like to see Threads moved up to hbase-commons in that case though.

bq. It looks like the manufactored threads do not follow current thread naming conventions
either where thread source is prefix on name, etc.

Just following the existing naming it was using. 

Sounds like we should do the backport of the current patch to 0.94, but into the util package.
Then we do another patch to move the current (0.96) into Threads and that up into hbase-commons.
Thoughts?
                
> Extract daemon thread factory from HTable into its own class
> ------------------------------------------------------------
>
>                 Key: HBASE-6568
>                 URL: https://issues.apache.org/jira/browse/HBASE-6568
>             Project: HBase
>          Issue Type: Sub-task
>    Affects Versions: 0.96.0
>            Reporter: Jesse Yates
>            Assignee: Jesse Yates
>             Fix For: 0.96.0
>
>         Attachments: hbase-6568-addendum.patch, java_HBASE-6568-v0.patch
>
>
> The DaemonThreadFactory in HTable is a really nice utility that is useful in multiple
places. We should pull out into a standalone class.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

Mime
View raw message