hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "nkeywal (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-6414) Remove the WritableRpcEngine & associated Invocation classes
Date Tue, 21 Aug 2012 10:06:38 GMT

    [ https://issues.apache.org/jira/browse/HBASE-6414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13438573#comment-13438573
] 

nkeywal commented on HBASE-6414:
--------------------------------

For this
{noformat}
   /**
-   * Construct an IPC client whose values are of the given {@link Writable}
+   * Construct an IPC client whose values are of the {@link Message}
    * class.
    * @param valueClass value class
    * @param conf configuration
    * @param factory socket factory
    */
-  public HBaseClient(Class<? extends Writable> valueClass, Configuration conf,
-      SocketFactory factory) {
-    this.valueClass = valueClass;
+  public HBaseClient(Configuration conf, SocketFactory factory) {
{noformat}

The javadoc was not updated, nor in ipc/ClientCache.java.
I'm fixing it in HBASE-6364. I didn't check if there were other stuff like this.
                
> Remove the WritableRpcEngine & associated Invocation classes
> ------------------------------------------------------------
>
>                 Key: HBASE-6414
>                 URL: https://issues.apache.org/jira/browse/HBASE-6414
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 0.96.0
>            Reporter: Devaraj Das
>            Assignee: Devaraj Das
>             Fix For: 0.96.0
>
>         Attachments: 6414-1.patch.txt, 6414-3.patch.txt, 6414-4.patch.txt, 6414-4.patch.txt,
6414-5.patch.txt, 6414-5.patch.txt, 6414-5.patch.txt, 6414-6.patch.txt, 6414-6.patch.txt,
6414-6.txt, 6414-initial.patch.txt, 6414-initial.patch.txt, 6414-v7.txt
>
>
> Remove the WritableRpcEngine & Invocation classes once HBASE-5705 gets committed
and all the protocols are rebased to use PB.
> Raising this jira in advance..

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message