hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "nkeywal (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-6234) Move simple KeyValue tests to hbase-common module
Date Fri, 31 Aug 2012 17:49:08 GMT

    [ https://issues.apache.org/jira/browse/HBASE-6234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13446173#comment-13446173
] 

nkeywal commented on HBASE-6234:
--------------------------------

bq. the single line itself
It main purpose was that it's executed within the JVM on hadoop-qa. That's how we found that
our ulimit were not taking into account on hadoop-qa. I now use it to see that the test has
actually started & finished in the logs. There's no impact on test coverage if we don't
have it. I would be lazy here I think: don't spend time to remove it when it works, don't
spend time to make it work when it doesn't. We fix/remove it when (if) we need it.

bq. hbase-common all run in the one JVM
It would work short term imho. If we could, it would be better not to have this as a prerequiste,
we can imagine having a lot of stuff there, with maybe long running tests or tests playing
with the environment (typical stuff: using defaultEdgeEnvironment to manipulate the time needs
to be done in isolation as it's a static). In the same area, if we share code around thread
management, with extreme/error cases (too many threads & so on), it's better to do it
on another jvm. I guess there are other example

bq. Leakage tools
Yes, really the main advantage is that it runs on hadoop qa as well. 

                
> Move simple KeyValue tests to hbase-common module
> -------------------------------------------------
>
>                 Key: HBASE-6234
>                 URL: https://issues.apache.org/jira/browse/HBASE-6234
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 0.96.0
>            Reporter: Matt Corgan
>            Assignee: Matt Corgan
>             Fix For: 0.96.0
>
>         Attachments: HBASE-6234-v1.patch, HBASE-6234-v2.patch
>
>
> TestKeyValue, LoadTestKVGenerator, and TestLoadTestKVGenerator should move up to hbase-common.
 This brings MD5Hash up as a dependency as well.
> To play well with Maven as discussed in HBASE-6162, I moved LoadTestKVGenerator from
the src/test folder to src/main folder so that tests in other modules can see it.  A couple
other files' import statements were affected by this.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message