hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Baranau (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-4364) Filters applied to columns not in the selected column list are ignored
Date Thu, 16 Aug 2012 12:45:38 GMT

    [ https://issues.apache.org/jira/browse/HBASE-4364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13435933#comment-13435933
] 

Alex Baranau commented on HBASE-4364:
-------------------------------------

bq. {noformat}
return ReturnCode.NEXT_ROW; // it should be "return ReturnCode.SKIP;"
{noformat}

Changing to SKIP would help to get the correct results for sure. But I'd highly doubt that
in this case it will work correct internally. I.e. I believe it would still apply filter to
all columns, but because any of these applications of filter doesn't affect the decision on
whether include the whole row or not this works. But in the essence (applying filter to all
columns instead of selected) this might work incorrect internally.

That's why I added this unit-test, which actually verifies that *filter applied to selected
columns only* (and decisions about filtering rows are based on filters applied to selected
columns only).
                
> Filters applied to columns not in the selected column list are ignored
> ----------------------------------------------------------------------
>
>                 Key: HBASE-4364
>                 URL: https://issues.apache.org/jira/browse/HBASE-4364
>             Project: HBase
>          Issue Type: Bug
>          Components: filters
>    Affects Versions: 0.90.4, 0.92.0, 0.94.0
>            Reporter: Todd Lipcon
>            Priority: Critical
>         Attachments: HBASE-4364-failing-test-with-simplest-custom-filter.patch, hbase-4364_trunk.patch,
hbase-4364_trunk-v2.patch
>
>
> For a scan, if you select some set of columns using addColumns(), and then apply a SingleColumnValueFilter
that restricts the results based on some other columns which aren't selected, then those filter
conditions are ignored.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message