Return-Path: 
 <issues-return-53554-apmail-hbase-issues-archive=hbase.apache.org@hbase.apache.org>
X-Original-To: apmail-hbase-issues-archive@www.apache.org
Delivered-To: apmail-hbase-issues-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id D8FFBD982
	for <apmail-hbase-issues-archive@www.apache.org>;
 Sun,  1 Jul 2012 16:24:47 +0000 (UTC)
Received: (qmail 65569 invoked by uid 500); 1 Jul 2012 16:24:47 -0000
Delivered-To: apmail-hbase-issues-archive@hbase.apache.org
Received: (qmail 65538 invoked by uid 500); 1 Jul 2012 16:24:47 -0000
Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@hbase.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@hbase.apache.org>
List-Post: <mailto:issues@hbase.apache.org>
List-Id: <issues.hbase.apache.org>
Delivered-To: mailing list issues@hbase.apache.org
Received: (qmail 65530 invoked by uid 99); 1 Jul 2012 16:24:47 -0000
Received: from issues-vm.apache.org (HELO issues-vm) (140.211.11.160)
    by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 01 Jul 2012 16:24:47 +0000
Received: from isssues-vm.apache.org (localhost [127.0.0.1])
	by issues-vm (Postfix) with ESMTP id CDE88142852
	for <issues@hbase.apache.org>; Sun,  1 Jul 2012 16:24:45 +0000 (UTC)
Date: Sun, 1 Jul 2012 16:24:45 +0000 (UTC)
From: "Zhihong Ted Yu (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <872557976.76648.1341159885844.JavaMail.jiratomcat@issues-vm>
In-Reply-To: <1880560647.63806.1340831624173.JavaMail.jiratomcat@issues-vm>
Subject: [jira] [Commented] (HBASE-6284) Introduce
 HRegion#doMiniBatchDelete()
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/HBASE-6284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13404760#comment-13404760 ] 

Zhihong Ted Yu commented on HBASE-6284:
---------------------------------------

The handling of:
{code}
  public MultiResponse multi(final RpcController controller,
      final MultiRequest request) throws ServiceException {
{code}
is correct. However, MultiAction might be interleaved such that the Puts and Deletes are separated by Appends and Increments.
The folloing code may result in frequent calls to doBatchOp():
{code}
              if (type != MutateType.PUT && type != MutateType.DELETE) {
                if (!mutates.isEmpty()) {
                  doBatchOp(builder, region, mutates);
                  mutates.clear();
{code}
Can we buffer Appends and Increments so that mutates List contains certain amount of Mutate's ?
                
> Introduce HRegion#doMiniBatchDelete()
> -------------------------------------
>
>                 Key: HBASE-6284
>                 URL: https://issues.apache.org/jira/browse/HBASE-6284
>             Project: HBase
>          Issue Type: Bug
>          Components: performance, regionserver
>            Reporter: Zhihong Ted Yu
>            Assignee: Anoop Sam John
>             Fix For: 0.96.0, 0.94.2
>
>         Attachments: HBASE-6284_Trunk-V2.patch, HBASE-6284_Trunk.patch
>
>
> From Anoop under thread 'Can there be a doMiniBatchDelete in HRegion':
> The HTable#delete(List<Delete>) groups the Deletes for the same RS and make one n/w call only. But within the RS, there will be N number of delete calls on the region one by one. This will include N number of HLog write and sync. If this also can be grouped can we get better performance for the multi row delete.
> I have made the new miniBatchDelete () and made the HTable#delete(List<Delete>) to call this new batch delete.
> Just tested initially with the one node cluster.  In that itself I am getting a performance boost which is very much promising.
> Only one CF and qualifier.
> 10K total rows delete with a batch of 100 deletes. Only deletes happening on the table from one thread.
> With the new way the net time taken is reduced by more than 1/10
> Will test in a 4 node cluster also. I think it will worth doing this change.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira