Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id DF831DD65 for ; Sun, 1 Jul 2012 08:31:55 +0000 (UTC) Received: (qmail 63989 invoked by uid 500); 1 Jul 2012 08:31:55 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 63786 invoked by uid 500); 1 Jul 2012 08:31:54 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 63718 invoked by uid 99); 1 Jul 2012 08:31:52 -0000 Received: from issues-vm.apache.org (HELO issues-vm) (140.211.11.160) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 01 Jul 2012 08:31:52 +0000 Received: from isssues-vm.apache.org (localhost [127.0.0.1]) by issues-vm (Postfix) with ESMTP id 24FF31418F1 for ; Sun, 1 Jul 2012 08:31:52 +0000 (UTC) Date: Sun, 1 Jul 2012 08:31:52 +0000 (UTC) From: "Hadoop QA (JIRA)" To: issues@hbase.apache.org Message-ID: <448262345.76336.1341131512153.JavaMail.jiratomcat@issues-vm> In-Reply-To: <1880560647.63806.1340831624173.JavaMail.jiratomcat@issues-vm> Subject: [jira] [Commented] (HBASE-6284) Introduce HRegion#doMiniBatchDelete() MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-6284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13404698#comment-13404698 ] Hadoop QA commented on HBASE-6284: ---------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12534145/HBASE-6284_Trunk-V2.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 hadoop2.0. The patch compiles against the hadoop 2.0 profile. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 7 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.TestZooKeeper Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2306//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2306//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2306//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2306//console This message is automatically generated. > Introduce HRegion#doMiniBatchDelete() > ------------------------------------- > > Key: HBASE-6284 > URL: https://issues.apache.org/jira/browse/HBASE-6284 > Project: HBase > Issue Type: Bug > Components: performance, regionserver > Reporter: Zhihong Ted Yu > Assignee: Anoop Sam John > Fix For: 0.96.0, 0.94.2 > > Attachments: HBASE-6284_Trunk-V2.patch, HBASE-6284_Trunk.patch > > > From Anoop under thread 'Can there be a doMiniBatchDelete in HRegion': > The HTable#delete(List) groups the Deletes for the same RS and make one n/w call only. But within the RS, there will be N number of delete calls on the region one by one. This will include N number of HLog write and sync. If this also can be grouped can we get better performance for the multi row delete. > I have made the new miniBatchDelete () and made the HTable#delete(List) to call this new batch delete. > Just tested initially with the one node cluster. In that itself I am getting a performance boost which is very much promising. > Only one CF and qualifier. > 10K total rows delete with a batch of 100 deletes. Only deletes happening on the table from one thread. > With the new way the net time taken is reduced by more than 1/10 > Will test in a 4 node cluster also. I think it will worth doing this change. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira