Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Sun, 22 Jul 2012 21:26:36 +0000 (UTC)
From: "stack (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <2114092470.88808.1342992396683.JavaMail.jiratomcat@issues-vm>
In-Reply-To: <1634995768.88275.1342983154466.JavaMail.jiratomcat@issues-vm>
Subject: [jira] [Commented] (HBASE-6440) SplitLogManager - log the exception
 when failed to move recovered edits.
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-6440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13420334#comment-13420334 ] 

stack commented on HBASE-6440:
------------------------------

+1 on patch.  This diff could not have caused the above fails.
                
> SplitLogManager - log the exception when failed to move recovered edits.
> ------------------------------------------------------------------------
>
>                 Key: HBASE-6440
>                 URL: https://issues.apache.org/jira/browse/HBASE-6440
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>         Attachments: hbase-6440.patch
>
>
> We should log the exception itself too:
> {noformat}
>         try {
>           HLogSplitter.moveRecoveredEditsFromTemp(tmpname, logfile, conf);
>         } catch (IOException e) {
>           LOG.warn("Could not finish splitting of log file " + logfile);
>           return Status.ERR;
>         }
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira