Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Wed, 11 Jul 2012 22:45:35 +0000 (UTC)
From: "Jimmy Xiang (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <2107491257.38653.1342046735473.JavaMail.jiratomcat@issues-vm>
In-Reply-To: <312216453.7506.1341476435615.JavaMail.jiratomcat@issues-vm>
Subject: [jira] [Commented] (HBASE-6331) Problem with HBCK mergeOverlaps
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-6331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13412261#comment-13412261 ] 

Jimmy Xiang commented on HBASE-6331:
------------------------------------

I don't think this is a bug.  In hbck, the last endkey is not the normal empty byte[].
Instead, it is changed to null. So we have a special comparator.
                
> Problem with HBCK mergeOverlaps
> -------------------------------
>
>                 Key: HBASE-6331
>                 URL: https://issues.apache.org/jira/browse/HBASE-6331
>             Project: HBase
>          Issue Type: Bug
>          Components: hbck
>            Reporter: Anoop Sam John
>            Assignee: Anoop Sam John
>             Fix For: 0.96.0, 0.94.1
>
>         Attachments: HBASE-6331_94.patch, HBASE-6331_Trunk.patch
>
>
> In HDFSIntegrityFixer#mergeOverlaps(), there is a logic to create the final range of the region after the overlap.
> I can see one issue with this code
> {code}
>             if (RegionSplitCalculator.BYTES_COMPARATOR
>                     .compare(hi.getEndKey(), range.getSecond()) > 0) {
>               range.setSecond(hi.getEndKey());
>             }
> {code}
> Here suppose the regions include the end region for which the endKey will be empty, we need to get finally the range with endkey as empty byte[]
> But as per the above logic it will see that any other key greater than the empty byte[] and will set it.
> Finally the new region created will not get endkey as empty byte[]

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira