Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Thu, 19 Jul 2012 16:28:34 +0000 (UTC)
From: "Alex Baranau (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <1819520565.76373.1342715314844.JavaMail.jiratomcat@issues-vm>
In-Reply-To: <64627743.66294.1342562375159.JavaMail.jiratomcat@issues-vm>
Subject: [jira] [Commented] (HBASE-6411) Move Master Metrics to metrics 2
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-6411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13418417#comment-13418417 ] 

Alex Baranau commented on HBASE-6411:
-------------------------------------

To sum up:

To me, with approach in this patch, we *really* create *shim for hadoop classes* as opposed to moving HBase classes (metric sources implementations and such) into the shim layer. This way every class/interface from hadoop-compat acts as a shim for hadoop class, which makes it easier to switch to actual implementation later down the road. I'd say we may be should follow this logic when adding things into the shim layer.

But there might be a con to that: we have to provide shim for more classes with this approach. Though still it looks like there shouldn't be many of them. For now the difference boils down to two extra Mutable metrics classes.
                
> Move Master Metrics to metrics 2
> --------------------------------
>
>                 Key: HBASE-6411
>                 URL: https://issues.apache.org/jira/browse/HBASE-6411
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Elliott Clark
>            Assignee: Alex Baranau
>         Attachments: HBASE-6411_concept.patch
>
>
> Move Master Metrics to metrics 2

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira