Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Sat, 21 Jul 2012 21:19:35 +0000 (UTC)
From: "Jimmy Xiang (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <1734538312.86757.1342905575873.JavaMail.jiratomcat@issues-vm>
In-Reply-To: <97081069.42803.1342114054833.JavaMail.jiratomcat@issues-vm>
Subject: [jira] [Commented] (HBASE-6381) AssignmentManager should use the
 same logic for clean startup and failover
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-6381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13419951#comment-13419951 ] 

Jimmy Xiang commented on HBASE-6381:
------------------------------------

@Ram, currently, I was thinking about three changes.  I need to make sure they are good.
1. for the failover case, let SSH take case of those dead region servers so that we can share some code instead of doing some similar things in AM and SSH.
2. SSH is enabled so that we can handle meta/root region server failure before joinCluster is completed.  However, we can hold SSH a little bit
for the user region assignments.  So in AM, we can avoid failoverProcessedRegions which is a little bit confusing.
3. those enablingTables and disablingTables, they should be some local variables. We can load them from ZKTable at the beginning instead of
handling them per table.
                
> AssignmentManager should use the same logic for clean startup and failover
> --------------------------------------------------------------------------
>
>                 Key: HBASE-6381
>                 URL: https://issues.apache.org/jira/browse/HBASE-6381
>             Project: HBase
>          Issue Type: Bug
>          Components: master
>            Reporter: Jimmy Xiang
>            Assignee: Jimmy Xiang
>
> Currently AssignmentManager handles clean startup and failover very differently.
> Different logic is mingled together so it is hard to find out which is for which.
> We should clean it up and share the same logic so that AssignmentManager handles
> both cases the same way.  This way, the code will much easier to understand and
> maintain.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira