Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Thu, 12 Jul 2012 22:23:34 +0000 (UTC)
From: "Andrew Wang (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <160306847.44626.1342131814945.JavaMail.jiratomcat@issues-vm>
In-Reply-To: <788582677.39750.1342059575344.JavaMail.jiratomcat@issues-vm>
Subject: [jira] [Commented] (HBASE-6377) HBASE-5533 metrics miss all
 operations submitted via MultiAction
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-6377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13413296#comment-13413296 ] 

Andrew Wang commented on HBASE-6377:
------------------------------------

Please correct my understanding on this if I'm wrong, but estimating via the average (total latency / num ops) is pretty undesirable for both normal MultiActions and the batched put MultiAction case. Latency from a slow op bleeds over to a fast one, which messes up per-op metrics. This would also affect doing per-region or per-column family metrics in the future, for the same reasons.

I haven't looked at the code, but is it possible to do more accurate accounting of the latency of each op in a MultiAction? If so, I think it'd be worthwhile.
                
> HBASE-5533 metrics miss all operations submitted via MultiAction
> ----------------------------------------------------------------
>
>                 Key: HBASE-6377
>                 URL: https://issues.apache.org/jira/browse/HBASE-6377
>             Project: HBase
>          Issue Type: Bug
>          Components: metrics, regionserver
>    Affects Versions: 0.96.0, 0.94.1
>            Reporter: Andrew Purtell
>            Assignee: Andrew Purtell
>             Fix For: 0.94.2
>
>         Attachments: 6377-0.94.patch, 6377-trunk-simple.patch, 6377.patch
>
>
> A client application (LoadTestTool) calls put() on HTables. Internally to the HBase client those puts are batched into MultiActions. The total number of put operations shown in the RegionServer's put metrics histogram never increases from 0 even though millions of such operations are made. Needless to say the latency for those operations are not measured either. The value of HBASE-5533 metrics are suspect given the client will batch put and delete ops like this.
> I had a fix in progress but HBASE-6284 messed it up. Before, MultiAction processing in HRegionServer would distingush between puts and deletes and dispatch them separately. It was easy to account for the time for them. Now both puts and deletes are submitted in batch together as mutations.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira