Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id DB1E1D4EC for ; Sun, 1 Jul 2012 00:29:53 +0000 (UTC) Received: (qmail 6013 invoked by uid 500); 1 Jul 2012 00:29:53 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 5966 invoked by uid 500); 1 Jul 2012 00:29:53 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 5954 invoked by uid 99); 1 Jul 2012 00:29:53 -0000 Received: from issues-vm.apache.org (HELO issues-vm) (140.211.11.160) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 01 Jul 2012 00:29:53 +0000 Received: from isssues-vm.apache.org (localhost [127.0.0.1]) by issues-vm (Postfix) with ESMTP id C050B1418B6 for ; Sun, 1 Jul 2012 00:29:51 +0000 (UTC) Date: Sun, 1 Jul 2012 00:29:51 +0000 (UTC) From: "Lars Hofhansl (JIRA)" To: issues@hbase.apache.org Message-ID: <1521656713.76070.1341102591789.JavaMail.jiratomcat@issues-vm> In-Reply-To: <956189588.75368.1341073846470.JavaMail.jiratomcat@issues-vm> Subject: [jira] [Commented] (HBASE-6296) Refactor EventType to track its own ExecutorService type MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-6296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13404659#comment-13404659 ] Lars Hofhansl commented on HBASE-6296: -------------------------------------- +1 on v1 > Refactor EventType to track its own ExecutorService type > -------------------------------------------------------- > > Key: HBASE-6296 > URL: https://issues.apache.org/jira/browse/HBASE-6296 > Project: HBase > Issue Type: Improvement > Components: master > Affects Versions: 0.96.0 > Reporter: Jesse Yates > Assignee: Jesse Yates > Priority: Minor > Fix For: 0.96.0 > > Attachments: 6296v1.txt, java_hbase-6296-v0.patch, java_hbase-6296-v0.patch > > > Currently there is a massive switch statement in org.apache.hadoop.hbase.executor.ExecutorService for the ExecutorType for each org.apache.hadoop.hbase.executor.EventHandler.EventType. This means is you add an new event type, you will also have to change the executorservice file, if for nothing but to add the executor type. Instead the EventType should just be able to keep track of which executor it should use. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira