Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 08720CF83 for ; Fri, 27 Jul 2012 22:22:35 +0000 (UTC) Received: (qmail 24672 invoked by uid 500); 27 Jul 2012 22:22:34 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 24634 invoked by uid 500); 27 Jul 2012 22:22:34 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 24625 invoked by uid 99); 27 Jul 2012 22:22:34 -0000 Received: from issues-vm.apache.org (HELO issues-vm) (140.211.11.160) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 27 Jul 2012 22:22:34 +0000 Received: from isssues-vm.apache.org (localhost [127.0.0.1]) by issues-vm (Postfix) with ESMTP id 7FD17142823 for ; Fri, 27 Jul 2012 22:22:34 +0000 (UTC) Date: Fri, 27 Jul 2012 22:22:34 +0000 (UTC) From: "Zhihong Ted Yu (JIRA)" To: issues@hbase.apache.org Message-ID: <146939121.112089.1343427754530.JavaMail.jiratomcat@issues-vm> In-Reply-To: <322155279.111994.1343425474806.JavaMail.jiratomcat@issues-vm> Subject: [jira] [Commented] (HBASE-6468) RowCounter may return incorrect result if column name is specified in command line MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-6468?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13424189#comment-13424189 ] Zhihong Ted Yu commented on HBASE-6468: --------------------------------------- {code} + if (!scanHasColumns) { + scan.setFilter(new FirstKeyOnlyFilter()); + } {code} Can we enhance FirstKeyOnlyFilter so that the filter checks for designated column before returning ReturnCode.NEXT_ROW ? The rationale is that we want to speed up scan in case the designated column appears in the first half of the row. Please generate patch for trunk first. No year is needed in license header. Thanks > RowCounter may return incorrect result if column name is specified in command line > ---------------------------------------------------------------------------------- > > Key: HBASE-6468 > URL: https://issues.apache.org/jira/browse/HBASE-6468 > Project: HBase > Issue Type: Bug > Affects Versions: 0.90.5 > Reporter: Shrijeet Paliwal > Attachments: 0001-HBASE-6468-RowCounter-may-return-incorrect-result.patch > > > The RowCounter use FirstKeyOnlyFilter regardless of whether or not the > command line argument specified a column family (or family:qualifier). > In case when no qualifier was specified as argument, the scan will > give correct result. However in the other case the scan instance may > have been set with columns other than the very first column in the > row, causing scan to get nothing as the FirstKeyOnlyFilter removes > everything else. > https://issues.apache.org/jira/browse/HBASE-6042 is related. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira