Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Tue, 3 Jul 2012 18:12:20 +0000 (UTC)
From: "Lars Hofhansl (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <114613271.429.1341339140843.JavaMail.jiratomcat@issues-vm>
In-Reply-To: <1137858766.71220.1340969863894.JavaMail.jiratomcat@issues-vm>
Subject: [jira] [Updated] (HBASE-6293) HMaster does not go down while
 splitting logs even if explicit shutdown is called.
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/HBASE-6293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lars Hofhansl updated HBASE-6293:
---------------------------------

    Attachment: 6293.txt

Simple patch.
                
> HMaster does not go down while splitting logs even if explicit shutdown is called.
> ----------------------------------------------------------------------------------
>
>                 Key: HBASE-6293
>                 URL: https://issues.apache.org/jira/browse/HBASE-6293
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.92.1, 0.94.0
>            Reporter: rajeshbabu
>            Assignee: rajeshbabu
>             Fix For: 0.92.2, 0.96.0, 0.94.1
>
>         Attachments: 6293.txt
>
>
> When master starts up and tries to do splitlog, in case of any error we try to do that infinitely in a loop until it succeeds.
> But now if we get a shutdown call, inside SplitLogManager
> {code}
>           if (stopper.isStopped()) {
>             LOG.warn("Stopped while waiting for log splits to be completed");
>             return;
>           }
> {code}
> Here we know that the master has stopped.  As the task may not be completed now
> {code}
>  if (batch.done != batch.installed) {
>       batch.isDead = true;
>       tot_mgr_log_split_batch_err.incrementAndGet();
>       LOG.warn("error while splitting logs in " + logDirs +
>       " installed = " + batch.installed + " but only " + batch.done + " done");
>       throw new IOException("error or interrupt while splitting logs in "
>           + logDirs + " Task = " + batch);
>     }
> {code} 
> we throw an exception.  In MasterFileSystem.splitLogAfterStartup() we don't check if the master is stopped and we try continously. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira