Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Thu, 12 Jul 2012 03:31:35 +0000 (UTC)
From: "Anoop Sam John (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <1096211911.39968.1342063895118.JavaMail.jiratomcat@issues-vm>
In-Reply-To: 
 <1943215695.60409.1336972794518.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (HBASE-5997) Fix concerns raised in HBASE-5922
 related to HalfStoreFileReader
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-5997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13412480#comment-13412480 ] 

Anoop Sam John commented on HBASE-5997:
---------------------------------------

bq. Is it possible if the file is empty say that we'll seek on every invocation of getFirstKey?
Yes as the check is against firstKey being not null. May be we can have a boolean variable based check.
As this is rare chance and the existance of the half file also wont be for more time( normally) I thought may be okey. What do u say Stack? If you feel I can change this.

bq.This patch does not do you your compare of row only rather than compare of full key. Is it supposed to?
Yes. You can see that the comparison now is against the first key in the file rather than the split key
{code}
-          if (getComparator().compare(key, offset, length, splitkey, 0,
-              splitkey.length) < 0) {
+          byte[] fk = getFirstKey();
+          // This will be null when the file is empty in which we can not seekBefore to any key
+          if (fk == null) return false;
+          if (getComparator().compare(key, offset, length, fk, 0,
+              fk.length) <= 0) {
{code}
So it is okey to have the full key based compare.[Not rowkey alone]
                
> Fix concerns raised in HBASE-5922 related to HalfStoreFileReader
> ----------------------------------------------------------------
>
>                 Key: HBASE-5997
>                 URL: https://issues.apache.org/jira/browse/HBASE-5997
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.90.6, 0.92.1, 0.94.0, 0.96.0
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: Anoop Sam John
>             Fix For: 0.94.2
>
>         Attachments: HBASE-5997_0.94.patch, HBASE-5997_94 V2.patch, Testcase.patch.txt
>
>
> Pls refer to the comment
> https://issues.apache.org/jira/browse/HBASE-5922?focusedCommentId=13269346&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13269346.
> Raised this issue to solve that comment. Just incase we don't forget it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira