Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
Date: Fri, 13 Jul 2012 03:57:34 +0000 (UTC)
From: "Anoop Sam John (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <1049953023.46310.1342151854967.JavaMail.jiratomcat@issues-vm>
In-Reply-To: <1681886169.13341.1341566555487.JavaMail.jiratomcat@issues-vm>
Subject: [jira] [Commented] (HBASE-6338) Cache Method in RPC handler
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HBASE-6338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13413470#comment-13413470 ] 

Anoop Sam John commented on HBASE-6338:
---------------------------------------

+      sb.append("-");

Better to call StringBuilder#append(char c) for appending the character.
sb.append('-')
                
> Cache Method in RPC handler
> ---------------------------
>
>                 Key: HBASE-6338
>                 URL: https://issues.apache.org/jira/browse/HBASE-6338
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: binlijin
>         Attachments: HBASE-6338-90.patch, HBASE-6338-92.patch, HBASE-6338-94.patch, HBASE-6338-trunk.patch
>
>
> Every call in rpc handler a Method will be created, if we cache the method will improve a little.
> I test with 0.90, Average Class.getMethod(String name, Class... parameterTypes) cost 4780 ns , if we cache it cost 2620 ns.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira