hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Purtell (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-6377) HBASE-5533 metrics miss all operations submitted via MultiAction
Date Thu, 12 Jul 2012 21:19:34 GMT

    [ https://issues.apache.org/jira/browse/HBASE-6377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13413234#comment-13413234
] 

Andrew Purtell commented on HBASE-6377:
---------------------------------------

Tangentially, if we're doing all over the place a lot of this get nanos then get them again
and subtract the diff, we might want to just use Guava's Stopwatch. Also, in our internal
version of 0.94 we've scaled metrics to milliseconds. The Stopwatch javadocs talk about that:
"Note that the overhead of measurement can be more than a microsecond, so it is generally
not useful to specify TimeUnit.NANOSECONDS precision here." For another JIRA perhaps.
                
> HBASE-5533 metrics miss all operations submitted via MultiAction
> ----------------------------------------------------------------
>
>                 Key: HBASE-6377
>                 URL: https://issues.apache.org/jira/browse/HBASE-6377
>             Project: HBase
>          Issue Type: Bug
>          Components: metrics, regionserver
>    Affects Versions: 0.96.0, 0.94.1
>            Reporter: Andrew Purtell
>            Assignee: Andrew Purtell
>             Fix For: 0.94.2
>
>         Attachments: 6377-0.94.patch, 6377-trunk-simple.patch, 6377.patch
>
>
> A client application (LoadTestTool) calls put() on HTables. Internally to the HBase client
those puts are batched into MultiActions. The total number of put operations shown in the
RegionServer's put metrics histogram never increases from 0 even though millions of such operations
are made. Needless to say the latency for those operations are not measured either. The value
of HBASE-5533 metrics are suspect given the client will batch put and delete ops like this.
> I had a fix in progress but HBASE-6284 messed it up. Before, MultiAction processing in
HRegionServer would distingush between puts and deletes and dispatch them separately. It was
easy to account for the time for them. Now both puts and deletes are submitted in batch together
as mutations.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message