hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-6370) Add compression codec test at HMaster when createTable/modifyColumn/modifyTable
Date Thu, 12 Jul 2012 15:20:36 GMT

    [ https://issues.apache.org/jira/browse/HBASE-6370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13412870#comment-13412870
] 

Hadoop QA commented on HBASE-6370:
----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12536226/6370v3.txt
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 hadoop2.0.  The patch compiles against the hadoop 2.0 profile.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    -1 javac.  The applied patch generated 5 javac compiler warnings (more than the trunk's
current 4 warnings).

    -1 findbugs.  The patch appears to introduce 8 new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

     -1 core tests.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.client.TestAdmin
                  org.apache.hadoop.hbase.regionserver.TestSplitTransactionOnCluster

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2369//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2369//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2369//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2369//console

This message is automatically generated.
                
> Add compression codec test at HMaster when createTable/modifyColumn/modifyTable
> -------------------------------------------------------------------------------
>
>                 Key: HBASE-6370
>                 URL: https://issues.apache.org/jira/browse/HBASE-6370
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: ShiXing
>            Assignee: ShiXing
>            Priority: Minor
>         Attachments: 6370v3.txt, HBASE-6370-trunk-V1.patch, HBASE-6370-trunk-V2.patch
>
>
> We deployed a cluster that none of the regionserver supports the compression codec such
like "lzo", but the cluster user/client does not know this, and he specifies the family's
compression codec by HColumnDescripto.setCompressionType(Compresson.Algorithm.LZO);
> Because the HBaseAdmin's createTable is async, so the client is waiting all the regions
of the table to be online forever. And client does not know why the regions are not online
until the HBase administrator find this problem.
> In deed, all of the regions are assigning by master, but regionserver's openHRegion always
failed.
> In my option, we can suppose all the cluster's enviroment are the same, means if the
master is deployed some lib, the regionserver should also be deployed. 
> Of course above is just a supposeļ¼Œ in real deployment, the hbase dba may just deploy
lib on regionserver or master.
> So I think this failure can be found earlier before master create the CreateTableHandler
thread, and we can tell client quickly we didn't support this compression codec type.
> I will upload the patch later.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

Mime
View raw message