hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Baranau (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HBASE-6411) Move Master Metrics to metrics 2
Date Thu, 26 Jul 2012 18:36:35 GMT

     [ https://issues.apache.org/jira/browse/HBASE-6411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Alex Baranau updated HBASE-6411:

    Attachment: HBASE-6411-3.patch

Tried to fix things we mentioned about. Created review request: https://reviews.apache.org/r/6161

Removed those incr() methods we were willing to (it turned out that they were only in hadoop
1.0 metrics2 lib, and were removed in hadoop 2.0, so we are ok removing it and no need to
ask hadoop guys about it).

Switched to using concurrent collections inside metric registries. It turned out that "synchronize-guarded"
methods where only in hadoop 2.0, not in hadoop 1.0. In both cases replaced them with working
with concurrent collections.

Tried to remove throwing MetricsExceptions, but there are still cases where I throw them.
Not sure what is the best way to avoid this in those particular cases. Advice is much appreciated.

Two Qs remained:
1. what about old MasterMetrics? Are we sure we want to replace it? I though we want to leave
it for some time
2. my Q from the comment above related to metricsSources interfaces - not critical, can be
addressed later, I guess.
> Move Master Metrics to metrics 2
> --------------------------------
>                 Key: HBASE-6411
>                 URL: https://issues.apache.org/jira/browse/HBASE-6411
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Elliott Clark
>            Assignee: Elliott Clark
>         Attachments: HBASE-6411-0.patch, HBASE-6411-1.patch, HBASE-6411-2.patch, HBASE-6411-3.patch,
> Move Master Metrics to metrics 2

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


View raw message