hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zhihong Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-6284) Introduce HRegion#doMiniBatchDelete()
Date Sun, 01 Jul 2012 16:24:45 GMT

    [ https://issues.apache.org/jira/browse/HBASE-6284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13404760#comment-13404760
] 

Zhihong Ted Yu commented on HBASE-6284:
---------------------------------------

The handling of:
{code}
  public MultiResponse multi(final RpcController controller,
      final MultiRequest request) throws ServiceException {
{code}
is correct. However, MultiAction might be interleaved such that the Puts and Deletes are separated
by Appends and Increments.
The folloing code may result in frequent calls to doBatchOp():
{code}
              if (type != MutateType.PUT && type != MutateType.DELETE) {
                if (!mutates.isEmpty()) {
                  doBatchOp(builder, region, mutates);
                  mutates.clear();
{code}
Can we buffer Appends and Increments so that mutates List contains certain amount of Mutate's
?
                
> Introduce HRegion#doMiniBatchDelete()
> -------------------------------------
>
>                 Key: HBASE-6284
>                 URL: https://issues.apache.org/jira/browse/HBASE-6284
>             Project: HBase
>          Issue Type: Bug
>          Components: performance, regionserver
>            Reporter: Zhihong Ted Yu
>            Assignee: Anoop Sam John
>             Fix For: 0.96.0, 0.94.2
>
>         Attachments: HBASE-6284_Trunk-V2.patch, HBASE-6284_Trunk.patch
>
>
> From Anoop under thread 'Can there be a doMiniBatchDelete in HRegion':
> The HTable#delete(List<Delete>) groups the Deletes for the same RS and make one
n/w call only. But within the RS, there will be N number of delete calls on the region one
by one. This will include N number of HLog write and sync. If this also can be grouped can
we get better performance for the multi row delete.
> I have made the new miniBatchDelete () and made the HTable#delete(List<Delete>)
to call this new batch delete.
> Just tested initially with the one node cluster.  In that itself I am getting a performance
boost which is very much promising.
> Only one CF and qualifier.
> 10K total rows delete with a batch of 100 deletes. Only deletes happening on the table
from one thread.
> With the new way the net time taken is reduced by more than 1/10
> Will test in a 4 node cluster also. I think it will worth doing this change.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message